Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Minimal test of Configuration/PyReleaseValidation/python/relval_steps.py validity #46910

Open
iarspider opened this issue Dec 11, 2024 · 6 comments

Comments

@iarspider
Copy link
Contributor

iarspider commented Dec 11, 2024

If I'm reading the code correctly, we construct all possible workflows on the fly. So, if we can change runTheMatrix (relval_steps.py to be excact) to throw an error on this line if constructed value of baseDataSetReleaseBetter[key] is weird - e.g. just 1, then, during PR testing, we could execute runTheMatrix -n (which lists all workflows and takes ~1 minute) and detect that error.

@AdrianoDee do you think it is a reasonable idea?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 11, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Dec 11, 2024

It could work, in principle one could directly check just before the loop if defaultDataSets has any empty ('') value (being initialized here).

My suspect is that there are many of the conditions defined in upgradeWorkflowComponents.py (and below for Run4) for which we don't have a defined input dataset, just because they are not really run regularly for RelVals (e.g. 2022postEE is not there).

@AdrianoDee
Copy link
Contributor

Anyway, I could have a draft implementing something like the check you propose. Most probably it will fail at the beginning. But we could iterate from that. I'll be able to have a look at it not before next week, though.

@makortel
Copy link
Contributor

assign pdmv

@cmsbuild
Copy link
Contributor

New categories assigned: pdmv

@AdrianoDee,@DickyChant,@miquork you have been requested to review this Pull request/Issue and eventually sign? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants