-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Minimal test of Configuration/PyReleaseValidation/python/relval_steps.py validity #46910
Comments
cms-bot internal usage |
A new Issue was created by @iarspider. @Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
It could work, in principle one could directly check just before the loop if My suspect is that there are many of the conditions defined in |
Anyway, I could have a draft implementing something like the check you propose. Most probably it will fail at the beginning. But we could iterate from that. I'll be able to have a look at it not before next week, though. |
assign pdmv |
New categories assigned: pdmv @AdrianoDee,@DickyChant,@miquork you have been requested to review this Pull request/Issue and eventually sign? Thanks |
If I'm reading the code correctly, we construct all possible workflows on the fly. So, if we can change
runTheMatrix
(relval_steps.py
to be excact) to throw an error on this line if constructed value ofbaseDataSetReleaseBetter[key]
is weird - e.g. just1
, then, during PR testing, we could executerunTheMatrix -n
(which lists all workflows and takes ~1 minute) and detect that error.@AdrianoDee do you think it is a reasonable idea?
The text was updated successfully, but these errors were encountered: