-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.6.X] backport PR7776 to 10_6_X gcc700 #8331
base: IB/CMSSW_10_6_X/gcc700
Are you sure you want to change the base?
[10.6.X] backport PR7776 to 10_6_X gcc700 #8331
Conversation
A new Pull Request was created by @menglu21 (Meng_Lu) for branch IB/CMSSW_10_6_X/gcc700. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test SiStripDAQ_O2O_test had ERRORS Comparison SummarySummary:
|
Hi, the error should no be related to the updates in this PR, do i understand it correct |
please test I agree the unit test failure does not belong to this change, let rerun the tests to get fresh results |
Hi @kdlong, please also have a check this PR meets your requirement |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test SiStripDAQ_O2O_test had ERRORS Comparison SummarySummary:
|
@menglu21 sorry I didn't see your comment. As far as I can tell this looks correct, it seems to add the needed sets, but I'm no expert in cmsdist. |
please test |
@smuzaffar could you please trigger a new test |
@menglu21 , you have managed to start the tests :-) |
ah, thanks, didn't realise that I have the permission and it already started :-) |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test SiStripDAQ_O2O_test had ERRORS Comparison SummarySummary:
|
Pull request #8331 was updated. |
Pull request #8331 was updated. |
@smuzaffar I think we still need it. btw, we also want a new special UL release icnluding newer pythia8, can I add it in this PR or create a new one after this one merged. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-919edb/38440/summary.html Comparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
assign generators @cms-sw/generators-l2 please review and sign this if it should go in 10.6.X |
New categories assigned: generators @alberto-sanchez,@bbilin,@GurpreetSinghChahal,@mkirsano,@menglu21,@SiewYan you have been requested to review this Pull request/Issue and eventually sign? Thanks |
+1 |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
as discussed in cms-sw/cmssw#37528, analyser would like to have it in CMSSW_10_6_X