Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KMTF LUT #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add KMTF LUT #1

wants to merge 1 commit into from

Conversation

zhenbinwu
Copy link

Initial

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

A new Pull Request was created by @zhenbinwu for branch main.

@epalencia, @smuzaffar, @cmsbuild, @aloeliger, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

cms-bot internal usage

@epalencia
Copy link

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/39285/summary.html
COMMIT: 8ab0d9d
CMSSW: CMSSW_14_1_X_2024-05-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-Phase2L1GMT/1/39285/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially added 17 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332476
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332450
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@zhenbinwu
Copy link
Author

@epalencia
Copy link

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/39340/summary.html
COMMIT: 8ab0d9d
CMSSW: CMSSW_14_1_X_2024-05-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-Phase2L1GMT/1/39340/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@zhenbinwu
Copy link
Author

Hi, since this PR passed the test, could it be merged? So that the GMT PR can move forward. Many thanks!

@zhenbinwu
Copy link
Author

@aloeliger Can you please sign off this PR as well? So that I can move the root file to CMS-data. Thanks

@aloeliger
Copy link

+l1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants