Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genproductions branch not being fully shown #46

Open
sihyunjeon opened this issue Jul 4, 2024 · 11 comments
Open

genproductions branch not being fully shown #46

sihyunjeon opened this issue Jul 4, 2024 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@sihyunjeon
Copy link
Contributor

When submitting jobs https://cms-pdmv-prod.web.cern.ch/gridpack/ some genproductions branch that exist in https://github.com/cms-sw/genproductions does not show up in the web interface

Expected Behavior

Every branch should be visible

Current Behavior

Only some selected branches are visible

Possible Solution

Is there a limitation for number of branches being rendered in the web interface?

Steps to Reproduce

  1. Click GEN productions tab in the web interface
  2. Compare the available branches in web interface and branches in https://github.com/cms-sw/genproductions

Context (Environment)

@sihyunjeon
Copy link
Contributor Author

Specifically mg2918_patch is not showing up

@sihyunjeon
Copy link
Contributor Author

@ggonzr

@ggonzr ggonzr self-assigned this Jul 4, 2024
@ggonzr ggonzr added the bug Something isn't working label Jul 4, 2024
@ggonzr
Copy link
Contributor

ggonzr commented Jul 4, 2024

Thanks for reporting this,

By default, GitHub API only retrieves the first 30 branches, (per_page attribute):

def get_git_branches(repository, cache=True):
"""
Return list of branches in the repostory
"""
if not cache or repository not in BRANCHES_CACHE:
headers = {"User-Agent": "Mozilla/5.0 (X11; Linux x86_64)"}
with ConnectionWrapper("https://api.github.com") as conn:
response = conn.api("GET", f"/repos/{repository}/branches", headers=headers)

I will provide a fix for this so that all branches are properly retrieved.

@sihyunjeon
Copy link
Contributor Author

ah ok meanwhile i'll clean up some branches there. not so urgent since i can do it this way to fix this. take your time! thanks

@sihyunjeon
Copy link
Contributor Author

can i modify the git issue?

i think it would be useful to have some allowed branch names that could be rendered in the web interface, like only allowing branch names starting with "release/", "patch/", "fix/" to be showing up in the interface (better for version control in the future as well for us since most of our submission works with master branch).

now i removed all the stupid branches so i am able to get what i want thanks for checking :) but this suggestion is for the future purposes

@sihyunjeon
Copy link
Contributor Author

@agrohsje @Cvico

@Cvico
Copy link

Cvico commented Jul 4, 2024

I'm not sure I understand the suggestion by @sihyunjeon. Would that imply e.g. renaming the mg265UL branch to something like release_mg265UL? I like the idea of having only some of them, the most important ones, showing in the interface though.

@sihyunjeon
Copy link
Contributor Author

sihyunjeon commented Jul 4, 2024

i think we should change the branch name to release_Run2UL and remove madgraph specifics ideally, but yes things like that. if it's a patch for testing purposes patch_Run2UL_madgraph352 something like this maybe

@Cvico
Copy link

Cvico commented Jul 4, 2024

Maybe it's easier to use github releases without changing the names of the branches? I'm worried about people getting confused / complaining of these changes. Like having a release Run2 UL in here.

@sihyunjeon
Copy link
Contributor Author

that was the original idea but i deprecated it and used branches instead since we had to make new releases even for small patch tests

@agrohsje
Copy link

agrohsje commented Nov 2, 2024

@sihyunjeon : Any follow-ups needed? Is this solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants