-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genproductions branch not being fully shown #46
Comments
Specifically mg2918_patch is not showing up |
Thanks for reporting this, By default, GitHub API only retrieves the first 30 branches, ( GridpackMachine/src/tools/utils.py Lines 135 to 143 in f3b97f7
I will provide a fix for this so that all branches are properly retrieved. |
ah ok meanwhile i'll clean up some branches there. not so urgent since i can do it this way to fix this. take your time! thanks |
can i modify the git issue? i think it would be useful to have some allowed branch names that could be rendered in the web interface, like only allowing branch names starting with "release/", "patch/", "fix/" to be showing up in the interface (better for version control in the future as well for us since most of our submission works with master branch). now i removed all the stupid branches so i am able to get what i want thanks for checking :) but this suggestion is for the future purposes |
I'm not sure I understand the suggestion by @sihyunjeon. Would that imply e.g. renaming the mg265UL branch to something like release_mg265UL? I like the idea of having only some of them, the most important ones, showing in the interface though. |
i think we should change the branch name to release_Run2UL and remove madgraph specifics ideally, but yes things like that. if it's a patch for testing purposes patch_Run2UL_madgraph352 something like this maybe |
Maybe it's easier to use github releases without changing the names of the branches? I'm worried about people getting confused / complaining of these changes. Like having a release Run2 UL in here. |
that was the original idea but i deprecated it and used branches instead since we had to make new releases even for small patch tests |
@sihyunjeon : Any follow-ups needed? Is this solved? |
When submitting jobs https://cms-pdmv-prod.web.cern.ch/gridpack/ some genproductions branch that exist in https://github.com/cms-sw/genproductions does not show up in the web interface
Expected Behavior
Every branch should be visible
Current Behavior
Only some selected branches are visible
Possible Solution
Is there a limitation for number of branches being rendered in the web interface?
Steps to Reproduce
Context (Environment)
The text was updated successfully, but these errors were encountered: