Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tt genMet filter #134

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add tt genMet filter #134

wants to merge 3 commits into from

Conversation

Cvico
Copy link
Contributor

@Cvico Cvico commented Jan 3, 2024

{
"gridpack_submit": false,
"gridpack_path" : "TT/TTto2L2Nu-3Jets_genMET-150_madgraphMLM-pythia8",
"fragment": ["Generator/ExternalLHEProducer_MadGraph5_aMCatNLO.dat", "PartonShower/madgraphMLM-pythia8-hepmcfilter.dat", "Filter/LHE_genMET150_filter.dat"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Carlos. Why do these samples use the hepmc filter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AH you are absolutely right, I must have missed that because I copied the json from the QCD one since it was an example for reusing gridpacks. I'll change it right away

@agrohsje
Copy link
Contributor

agrohsje commented Jan 9, 2024

I have a more general question: Should we think about naming conventions for filters and review what we have in terms of filters?

@sihyunjeon
Copy link
Contributor

I am not 100% sure if we can come up with full picture as we did for hard processes (although we still find some loop holes in our logics) since there are way too many diverse cases (in some sense i mean, we have more diverse hard processes but we have more computational-wise diversity for filters). So I am honestly fine with coming up with names as we tackle problems one by one and tell people that these are the tags we give as conventions (just like we do DYto2L instead of doing ZorGammaStarto2L).

I think one important thing to make our lives easier is to have the filter modules factorized. Like having a template of VpT filter and giving min and max inside the json fragments instead of having all of them separately created in txt files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants