Preliminary stuff for herwig #117

Cvico · 2023-10-22T14:01:36Z

Hi,

This is just a preliminary version of herwig config files for central herwig samples. There's no particular rush I think in having this implement in a short timescale, but I'm leaving the PR open just to have this in mind in the future. This might take a bit of time because if I'm not mistaken, it would require a bit of development in the backend.

I think there are a few things to discuss:

ExternalProducer: herwig requires to launch an script that merges lhe files before starting the shower step. This can be seen in the postGenerationCommand = cms.untracked.vstring('mergeLHE.py', '-i', 'thread*/cmsgrid_final.lhe', '-o', 'cmsgrid_final.lhe'), option in ExternalLHEProducer_Powheg-herwig7.dat.
Fragment: There are a few things to mention here.
- Center of mass energy and processParameters (which for herwig are often specific commands of herwig) can be configured using the same placeholders as for pythia8.
- I haven't found out what is the option configFiles = cms.vstring() in the fragment. Seems to me that this is to allow people to configure herwig commands using an input file that is a ".in" format. See the only example in cmssw that does not set this to just an empty variable here. This config points to this file.
Input process. I think for herwig samples we should have the mindset that by default these are variations of our commonly pythia8 showered samples. I've create the example I'm working now within TOP to test once the backend is set to consider herwig showers.

Cvico · 2023-10-22T14:02:24Z

One more comment. I'm not sure if maybe we can add a replaceable in the common ExternalLHEProducer-Powheg.dat file so that it can be used for this as well.

sihyunjeon · 2023-10-22T14:17:36Z

Fragments/Generator/ExternalLHEProducer_Powheg-herwig7.dat

+    outputFile = cms.string('cmsgrid_final.lhe'),
+    scriptName = cms.FileInPath('GeneratorInterface/LHEInterface/data/run_generic_tarball_cvmfs.sh'),
+    generateConcurrently = cms.untracked.bool($concurrentLHEforPowheg)
+    postGenerationCommand = cms.untracked.vstring('mergeLHE.py', '-i', 'thread*/cmsgrid_final.lhe', '-o', 'cmsgrid_final.lhe'),


hmm i would suggest to add this with a replaceable instead of having a new data file in case it's needed

sihyunjeon · 2023-10-22T14:18:10Z

Fragments/PartonShower/powheg-herwig7.dat

+from Configuration.Generator.Herwig7Settings.Herwig7CH3TuneSettings_cfi import *
+from Configuration.Generator.Herwig7Settings.Herwig7LHEPowhegSettings_cfi import *
+from Configuration.Generator.Herwig7Settings.Herwig7PSWeightsSettings_cfi import *
+from Configuration.Generator.Herwig7Settings.Herwig7_7p1SettingsFor7p2_cfi import *


not sure what this really does, are you aware of this?

Uhm that is loading the Herwig CH3 tuning right? Now what I'm not so sure is the Herwig7_7p1SettingsFor7p2_cfi, not sure if that's the latest.

we should ask dominic, forwarding an email to you

Hi, just to add here, the Herwig7_7p1SettingsFor7p2 set a number of UE settings which changed when going from Herwig 7.1 to 7.2 back to their 7.1 values, since this was the release used to make the CH tunes, and hence it's recommended to use it as part of the tune

@Dominic-Stafford wouldn't it make sense to add this to the CH settings? It will work with the old versions where this was already default and still with the new ones. We could make an entry in the fragment that these are not actual settings of the tune but default ones that have changed and where used to derive the tune. The current name is a bit confusing. I will still work with 7.3 and it is related to the tune not the general program, so people might only want it if they are using CH3.

Yes, maybe this would make sense, though it might also cause confusion for people taking parameters from old cards if we remove it. Maybe first I should ask Emyr is there was a motivation for making it a separate block? For 7.3 this might need to be expanded as maybe there will be further parameters which should be set back to their 7.1 values

sihyunjeon · 2023-10-22T14:18:19Z

Fragments/PartonShower/powheg-herwig7.dat

+
+from Configuration.Generator.Herwig7Settings.Herwig7LHECommonSettings_cfi import *
+from Configuration.Generator.Herwig7Settings.Herwig7StableParticlesForDetector_cfi import *
+from Configuration.Generator.Herwig7Settings.Herwig7CH3TuneSettings_cfi import *


we should make the tunes configurable

Cvico · 2023-10-23T12:22:41Z

Hi, I've updated the PR following Dominic's mail (thanks a lot for the info!!)

I also modified the ExternalLHEProducer_Powheg.dat card to have a replaceable "$additionalCommands" that can should be changed by whatever we put in the .json (see the example file under NewTests folder in powheg). If nothing is provided, it should automatically remove the replaceable (I'll ask geovanny to see if this can be done, because the decission should be made in the backend).

agrohsje · 2023-10-23T12:28:26Z

Cards/Powheg/NewTests/TWminustoLNu2Q_powheg-herwig7/TWminustoLNu2Q_powheg-herwig7.json

@@ -0,0 +1,14 @@
+{
+    "gridpack_submit": false,
+    "gridpack_path": "SingleT/ST_wtch_DR_slc7_amd64_gcc10_CMSSW_12_4_8_TWminustoLNu2Q_powheg-pythia8.tgz",


The fact that this is hard-coded here is just for testing ?

Dominic-Stafford · 2023-10-23T13:59:12Z

Hi, sorry, it's occurred to me it would probably be good to make these samples using the Herwig7HadronizerFilter rather than the old Herwig7GeneratorFilter. This is the change that fixes the issue of the wrong lhe events being saved due to Herwig silently skipping events, and is more relevant for mlm and FxFx where a lot of events get skipped in merging, but I think even for POWHEG Herwig will in some rare conditions veto an event, and this only need happen once for all subsequent events to have the wrong LHE information, so we should probably use the HadronizerFilter to be safe. How soon are you planning on producing these samples? The change hasn't made it into 12_4 yet, so should I ask the gen conveners to ask ORP for a new release?

agrohsje · 2023-10-23T14:46:11Z

Yes. Please do so. I think it is good to have this consistently in Run3.

Preliminary stuff for herwig

d1c1cb5

sihyunjeon reviewed Oct 22, 2023

View reviewed changes

Carlos Vico Villalba added 2 commits October 22, 2023 18:42

Added configurable tuning for herwig

2890503

Updated PR

0cfbf14

agrohsje reviewed Oct 23, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preliminary stuff for herwig #117

Preliminary stuff for herwig #117

Cvico commented Oct 22, 2023

Cvico commented Oct 22, 2023

sihyunjeon Oct 22, 2023

sihyunjeon Oct 22, 2023

Cvico Oct 22, 2023

sihyunjeon Oct 22, 2023 •

edited

Loading

Dominic-Stafford Oct 23, 2023 •

edited

Loading

agrohsje Oct 23, 2023

Dominic-Stafford Oct 23, 2023

sihyunjeon Oct 22, 2023

Cvico commented Oct 23, 2023

agrohsje Oct 23, 2023

Dominic-Stafford commented Oct 23, 2023

agrohsje commented Oct 23, 2023

Preliminary stuff for herwig #117

Are you sure you want to change the base?

Preliminary stuff for herwig #117

Conversation

Cvico commented Oct 22, 2023

Cvico commented Oct 22, 2023

sihyunjeon Oct 22, 2023

Choose a reason for hiding this comment

sihyunjeon Oct 22, 2023

Choose a reason for hiding this comment

Cvico Oct 22, 2023

Choose a reason for hiding this comment

sihyunjeon Oct 22, 2023 • edited Loading

Choose a reason for hiding this comment

Dominic-Stafford Oct 23, 2023 • edited Loading

Choose a reason for hiding this comment

agrohsje Oct 23, 2023

Choose a reason for hiding this comment

Dominic-Stafford Oct 23, 2023

Choose a reason for hiding this comment

sihyunjeon Oct 22, 2023

Choose a reason for hiding this comment

Cvico commented Oct 23, 2023

agrohsje Oct 23, 2023

Choose a reason for hiding this comment

Dominic-Stafford commented Oct 23, 2023

agrohsje commented Oct 23, 2023

sihyunjeon Oct 22, 2023 •

edited

Loading

Dominic-Stafford Oct 23, 2023 •

edited

Loading