Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a gAperture flag for AIS legs 1-3 #207

Open
cmillion opened this issue May 6, 2016 · 6 comments
Open

add a gAperture flag for AIS legs 1-3 #207

cmillion opened this issue May 6, 2016 · 6 comments
Assignees

Comments

@cmillion
Copy link
Owner

cmillion commented May 6, 2016

CAI mode only?

@cmillion cmillion added this to the v1.27.2 milestone Jun 2, 2016
@cmillion cmillion self-assigned this Jun 2, 2016
@cmillion cmillion added fixed and removed fixing labels Jun 21, 2016
cmillion added a commit that referenced this issue Jun 21, 2016
@cmillion
Copy link
Owner Author

The flag number is 256. I've also updated the User Guide.

@cmillion cmillion added fixing and removed fixed labels Jun 25, 2016
@cmillion
Copy link
Owner Author

As implemented, this adds substantial overhead to FUV light curve. In the time it took to generate ~4,000 NUV light curves, only ~260 were created in FUV. I'm trying to refactor it to be a little more reasonable.

@cmillion
Copy link
Owner Author

I'm deprecating this feature for now, until I have a burst of clever. I don't know how to handle common edge cases without making FUV unusably slow.

@cmillion
Copy link
Owner Author

I'm thinking now that the fastest and most robust way to do this might be to pre-build a table of time ranges delimiting the case where you have FUV CAI legs 1-3, and then download that whole table once at the beginning of each run and quickly check for overlaps.

@bshiao
Copy link
Collaborator

bshiao commented Jun 25, 2016

Yep, that makes sense, I’ll think about it

From: Chase Million [mailto:[email protected]]
Sent: Friday, June 24, 2016 10:54 PM
To: cmillion/gPhoton
Subject: Re: [cmillion/gPhoton] add a gAperture flag for AIS legs 1-3 (#207)

I'm thinking now that the fastest and most robust way to do this might be to pre-build a table of time ranges delimiting the case where you have FUV CAI legs 1-3, and then download that whole table once at the beginning of each run and quickly check for overlaps.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/207#issuecomment-228504493, or mute the threadhttps://github.com/notifications/unsubscribe/AGjjw_THERDl-Y1OyF5P-6v4P2eHNOkxks5qPJhcgaJpZM4IY1WS.

@cmillion cmillion removed the fixing label Jul 14, 2016
@cmillion cmillion removed this from the v1.27.2 milestone Jul 14, 2016
@cmillion
Copy link
Owner Author

Bumping this change to a later build version after we have a chance to build the above-discussed lookup table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants