Potential Predbat Interwork issue

[dbw1966]

See Predbat issue #1407.

Inconsistent PV today data spotted, coincident with logs in HA showing for example

2024-08-29 18:37:15.405 WARNING (MainThread) [homeassistant.helpers.template] Template variable warning: 'dict object' has no attribute 'solarPVAmps' when rendering '{{ value_json.solarPVAmps }}'
2024-08-29 19:37:16.917 WARNING (MainThread) [homeassistant.helpers.template] Template variable warning: 'dict object' has no attribute 'batterySOC' when rendering '{{ value_json.batterySOC }}'

Logfile attached.
HA Log DW 240830 1008.txt

Maybe error handling at Predbat not accurate?

[dbw1966]

Someone on FB pointed to an error in the code for sofar2mqtt. The last lines read

bool checkCRC(uint8_t frame[], byte frameSize)
{
unsigned int calculated_crc, received_crc;

received_crc = ((frame[frameSize-2] << 8) | frame[frameSize-1]);
calcCRC(frame, frameSize);
calculated_crc = ((frame[frameSize-2] << 8) | frame[frameSize-1]);
return (received_crc = calculated_crc);

}

And they should have read
bool checkCRC(uint8_t frame[], byte frameSize)
{
unsigned int calculated_crc, received_crc;

received_crc = ((frame[frameSize-2] << 8) | frame[frameSize-1]);
calcCRC(frame, frameSize);
calculated_crc = ((frame[frameSize-2] << 8) | frame[frameSize-1]);
return (received_crc == calculated_crc);

}

== is the comparitor that should have been used.

I will see if this fixes it.