Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in checkCRC() function #66

Open
watts-on-root opened this issue Sep 23, 2023 · 0 comments
Open

Bug in checkCRC() function #66

watts-on-root opened this issue Sep 23, 2023 · 0 comments

Comments

@watts-on-root
Copy link

Hi,

I just noticed there is a bug in the checkCRC function.
The last line should be:
return (received_crc == calculated_crc);
and not:
return (received_crc = calculated_crc);
Otherwise the function always returns true regardless of whether the CRC is correct or not.

Regards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@watts-on-root