Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: use legacyregister instead of new registry #694

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Aug 29, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:
Use compose-base/metrics instead of prometheus.Registry directly

This has several benefits:

  1. use the same Metrics as the clusterpedia apierver, and the metrics can be aggregated for display in the binding-apiserver command
  2. Golang Metrics and Process Metrics are now registered.
  3. more advanced functionality for future use of compose-base/metrics

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@clusterpedia-bot
Copy link

Hi @Iceber,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot
Copy link

@Iceber

Failed add label kind/features
Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@Iceber Iceber added the kind/feature New feature label Aug 29, 2024
@Iceber Iceber merged commit 5ddd31e into clusterpedia-io:main Aug 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants