Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout should cancel connection attempt #22

Closed
clue opened this issue Jul 7, 2015 · 4 comments
Closed

Timeout should cancel connection attempt #22

clue opened this issue Jul 7, 2015 · 4 comments
Labels
new feature
Milestone
v0.5.1

Comments

@clue
Copy link
Owner

clue commented Jul 7, 2015

Depends on reactphp/promise-timer#2
@clue
Copy link
Owner Author

clue commented Jul 15, 2015

Two tasks:

@clue
Copy link
Owner Author

clue commented Jul 16, 2015

We should also forward the cancellation request to the underlying Promise returned from the Connector: reactphp-legacy/socket-client#40

@clue
Copy link
Owner Author

clue commented Jul 16, 2015

Also keep in mind that cancellation support is only available with the Promise v2.1 API, which requires PHP 5.4. We should implement this in a way that PHP 5.3 is still supported, but could possibly skip cancellation support.

@clue clue mentioned this issue Sep 6, 2015
Closed
@clue clue added this to the v0.5.1 milestone Nov 21, 2016
@clue
Copy link
Owner Author

clue commented Nov 21, 2016

We should also forward the cancellation request to the underlying Promise returned from the Connector: reactphp-legacy/socket-client#40

Closed via #39

Remove timeout handling here once it's been implemented as part of reactphp-legacy/socket-client#28

See #40

@clue clue closed this as completed Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v0.5.1
Development

No branches or pull requests
1 participant
@clue