Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export errMissingFile error type #1138

Closed
kamikazechaser opened this issue Jun 14, 2024 · 1 comment · Fixed by #1141
Closed

Export errMissingFile error type #1138

kamikazechaser opened this issue Jun 14, 2024 · 1 comment · Fixed by #1141

Comments

@kamikazechaser
Copy link
Contributor

kamikazechaser commented Jun 14, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Feature request.

Describe the solution you'd like

Standard library exposes http.ErrMissingFile the same should be exposed by protocol. I can send a PR if this is within scope.

Describe alternatives you've considered

N/A

Additional context

This allows easy building of error handlers without performing string comparison/using errors.Is e.t.c.
@li-jin-gou
Copy link
Member

Can you submit a PR? @kamikazechaser ❤️

kamikazechaser added a commit to kamikazechaser/hertz that referenced this issue Jun 20, 2024
@kamikazechaser
feat: export ErrMissingFile
f8bd8a2 
* closes cloudwego#1138

This follows the std library approach: https://pkg.go.dev/net/http#ErrMissingFile
@kamikazechaser kamikazechaser mentioned this issue Jun 20, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: export ErrMissingFile kamikazechaser/hertz
2 participants
@kamikazechaser @li-jin-gou