From a85d402d5af518b05d586028f9bb7e1b5c9044ce Mon Sep 17 00:00:00 2001 From: Vitalii Tymchyshyn Date: Tue, 19 Sep 2023 15:24:01 -0700 Subject: [PATCH] [CDAP-20807] Update Guava version to match google libraries needs and ensure Errors (e.g. method not found) are properly propagated. --- .../cdap/cdap/internal/provision/task/DeprovisionTask.java | 2 +- .../cdap/cdap/internal/provision/task/ProvisionTask.java | 2 +- .../cdap/internal/provision/task/ProvisioningTask.java | 4 ++-- cdap-runtime-ext-dataproc/pom.xml | 7 ++++--- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/DeprovisionTask.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/DeprovisionTask.java index ede61bb829c3..50520064be85 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/DeprovisionTask.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/DeprovisionTask.java @@ -119,7 +119,7 @@ protected Map createSubTasks( } @Override - protected void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Exception e) { + protected void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Throwable e) { provisionerNotifier.orphaned(programRunId); } diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/ProvisionTask.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/ProvisionTask.java index 720b18f99765..9b545edb736a 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/ProvisionTask.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/ProvisionTask.java @@ -105,7 +105,7 @@ protected Map createSubTasks( } @Override - protected void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Exception e) { + protected void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Throwable e) { notifyFailed(e); } diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/ProvisioningTask.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/ProvisioningTask.java index 879dd060e5f3..4cd655642c12 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/ProvisioningTask.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/provision/task/ProvisioningTask.java @@ -157,7 +157,7 @@ public final long executeOnce() throws Exception { return 0; } catch (InterruptedException e) { throw e; - } catch (Exception e) { + } catch (Throwable e) { LOG.error("{} task failed in {} state for program run {} due to {}.", currentTaskInfo.getProvisioningOp().getType(), state, programRunId, Exceptions.condenseThrowableMessage(e), e); @@ -231,7 +231,7 @@ protected abstract Map createSubTask * @param taskInfo task info for the failure * @param e the non-retryable exception */ - protected abstract void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Exception e); + protected abstract void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Throwable e); /** * Logic to run when task info could not be saved to the ProvisionerStore. diff --git a/cdap-runtime-ext-dataproc/pom.xml b/cdap-runtime-ext-dataproc/pom.xml index cfd9811a6033..32f19de36c4d 100644 --- a/cdap-runtime-ext-dataproc/pom.xml +++ b/cdap-runtime-ext-dataproc/pom.xml @@ -63,9 +63,10 @@ com.google.guava guava - - 20.0 + + 32.1.2-jre commons-cli