From 7fbd144eab8c253c4ebba3fe2daca58a3991d506 Mon Sep 17 00:00:00 2001 From: suryakumari Date: Fri, 27 Oct 2023 12:12:11 +0530 Subject: [PATCH] incorporated review comments --- .../features/systemadmin/SysAdminRunTime.feature | 10 +++++----- .../io/cdap/cdap/common/common/TestRunnerRequired.java | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/cdap-e2e-tests/src/e2e-test/features/systemadmin/SysAdminRunTime.feature b/cdap-e2e-tests/src/e2e-test/features/systemadmin/SysAdminRunTime.feature index f35393993731..b435909ba8fa 100644 --- a/cdap-e2e-tests/src/e2e-test/features/systemadmin/SysAdminRunTime.feature +++ b/cdap-e2e-tests/src/e2e-test/features/systemadmin/SysAdminRunTime.feature @@ -29,7 +29,7 @@ Feature: Sysadmin - Validate system admin page Run time scenarios Then Verify the namespace created success message displayed on confirmation window Then Verify the created namespace: "namespaceName" is displayed in Namespace tab - @Required + @SysAdminRequired Scenario:To verify User should be able to add a secure key from Make HTTP calls successfully with PUT calls Given Open Datafusion Project to configure pipeline Then Open "System Admin" menu @@ -41,7 +41,7 @@ Feature: Sysadmin - Validate system admin page Run time scenarios Then Click on send button Then Verify the status code for success response - @Required + @SysAdminRequired Scenario:To verify User should be able to fetch secure key from Make HTTP calls successfully with GET calls Given Open Datafusion Project to configure pipeline Then Open "System Admin" menu @@ -52,7 +52,7 @@ Feature: Sysadmin - Validate system admin page Run time scenarios Then Click on send button Then Verify the status code for success response - @Required + @SysAdminRequired Scenario:To verify User should be able to delete secure key from Make HTTP calls successfully with DELETE calls Given Open Datafusion Project to configure pipeline Then Open "System Admin" menu @@ -63,7 +63,7 @@ Feature: Sysadmin - Validate system admin page Run time scenarios Then Click on send button Then Verify the status code for success response - @BQ_SOURCE_TEST @BQ_SINK_TEST @Required + @BQ_SOURCE_TEST @BQ_SINK_TEST @SysAdminRequired Scenario:To verify user should be able to run a pipeline successfully using the System preferences created Given Open Datafusion Project to configure pipeline Then Open "System Admin" menu @@ -101,7 +101,7 @@ Feature: Sysadmin - Validate system admin page Run time scenarios Then Open and capture logs Then Verify the pipeline status is "Succeeded" - @BQ_SOURCE_TEST @BQ_SINK_TEST @Required + @BQ_SOURCE_TEST @BQ_SINK_TEST @SysAdminRequired Scenario:To verify user should be able to run a pipeline successfully using the Namespace preferences created Given Open Datafusion Project to configure pipeline Then Open "System Admin" menu diff --git a/cdap-e2e-tests/src/e2e-test/java/io/cdap/cdap/common/common/TestRunnerRequired.java b/cdap-e2e-tests/src/e2e-test/java/io/cdap/cdap/common/common/TestRunnerRequired.java index b74e58165132..276564b9a097 100644 --- a/cdap-e2e-tests/src/e2e-test/java/io/cdap/cdap/common/common/TestRunnerRequired.java +++ b/cdap-e2e-tests/src/e2e-test/java/io/cdap/cdap/common/common/TestRunnerRequired.java @@ -20,13 +20,13 @@ import org.junit.runner.RunWith; /** - * Test Runner to execute required test cases. Add @Required tag on the scenario. + * Test Runner to execute required test cases. Add @SysAdminRequired tag on the scenario. */ @RunWith(Cucumber.class) @CucumberOptions( features = {"src/e2e-test/features"}, glue = {"stepsdesign", "io.cdap.cdap.common.stepsdesign"}, - tags = {"@Required"}, + tags = {"@SysAdminRequired"}, plugin = {"pretty", "html:target/cucumber-html-report/required", "json:target/cucumber-reports/cucumber-required.json", "junit:target/cucumber-reports/cucumber-required.xml"},