Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

Standard Configuration Change required at my.cnf.erb #225

Open
rbrihaspathi opened this issue May 15, 2019 · 3 comments
Open

Standard Configuration Change required at my.cnf.erb #225

rbrihaspathi opened this issue May 15, 2019 · 3 comments

Comments

@rbrihaspathi
Copy link

Thank you for submitting an issue.

Feature Request Info

Problem you are trying to solve

Help us understand the problem you are facing. Please provide as much context as possible.
pc.recovery value should be set to TRUE instead of FALSE. (in my.cnf.erb file, for
wsrep_provider_options parameter)

Proposed solution/feature

What is the proposed solution and why do you think it is the best approach to the problem above.
Value should be TRUE instead of False. When it is TRUE, Galera will save the database view state to file on disk when it shuts down and which will be easy to recover the db from the state where it was.

Would you want to open an PR for this feature?

Bug Report Info

Currently:

What is the current broken behavior?
Node recovery will not happen automatically.

Expected:

What the correct behavior should be?
Node should be recovered automatically.

Steps to Reproduce:

Please provide as much detail as possible.

Deployment Context:

Please provide relevant details about your deployment. That might include:

  • Are you using cf-mysql-release with a service broker?
  • How many nodes and proxies are deployed?
  • Other relevant deployment topology info
  • Release version
  • Other bosh releases deployed on the same vms

Reference:

Attach screenshot(s) or logs if relevant

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/166030030

The labels on this github issue will be updated when the story is started.

@bgandon
Copy link

bgandon commented Nov 15, 2019

Hi @menicosia, what do you guys thing about adopting this improvement, setting pc.recovery to true in order to improve nodes restarts?

@menicosia
Copy link
Contributor

menicosia commented Nov 16, 2019

Hi @rbrihaspathi and @bgandon,

We enabled pc.recovery=TRUE way back in v21 [#90573188], but then disabled it again in v36.11. Check out the reasoning in this story: #153572034 and let us know what you think.

If you agree that unfortunately, we should leave it as it is, then please close this issue. If there's a specific issue that you are seeing when operating these (we very rarely see the need for pc.recovery=TRUE) please let us know how the default is affecting you. That may influence our reasoning per above story, in addition to any experiences of our own.

Thanks for raising this issue!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

4 participants