CI pipeline for maintaining the release #35
Conversation
|
I should rework the contribution branch so that it does not include the version bumps themselves. They make the code review difficult and I can always cherry-pick those later on. |
…e job that bumps these packages
…Golang release v0.117.0
…ss update on all '*.yml' deployment manifests
…release' suffix convention
|
Here we go, that's cleaner. Worth to note, everything in the
|
rkoster
requested review from
a team,
ystros and
mvach
and removed request for
a team
|
As mentioned during working group meeting the shared golang scripts should be good to consume now: https://github.com/cloudfoundry/bosh-package-golang-release/tree/main/ci/tasks/shared |
| let "result+=$?" | ||
|
|
||
| echo -e "\n Running build script to confirm everything compiles..." | ||
| $bin/build | ||
| $bin/build-linux-amd64 | ||
| let "result+=$?" | ||
|
|
||
| echo -e "\n Running ginkgo tests..." | ||
| ginkgo -r . |
There was a problem hiding this comment.
Consider using go run github.com/onsi/ginkgo/v2/ginkgo here so that there isn't a need for a ginkgo binary to be installed in $PATH, and to ensure that the version used matches go.mod.
Example: https://github.com/cloudfoundry/bosh-agent/blob/main/bin/ginkgo#L5C1-L5C40
| @@ -5,14 +5,18 @@ result=0 | |||
| bin=$(dirname $0) | |||
|
|
|||
| echo -e "\n Formatting packages..." | |||
| go fmt github.com/cppforlife/bosh-virtualbox-cpi/... | |||
| go fmt bosh-virtualbox-cpi/... | |||
| let "result+=$?" | |||
There was a problem hiding this comment.
Maybe it makes sense to use set -e instead of the result+=$? pattern. It reduces conditionals, and ensures the script fails early.
Example: https://github.com/cloudfoundry/bosh-agent/blob/main/bin/ginkgo#L2
|
Thanks for the review, I'm going back to this |
|
@bgandon are still planning on coming back to this, or should we merge it as is? |
Gstack has developed a Concourse pipeline and demonstrated ability to update dependencies and ship a new release v0.4.3 using it:
Submitted here for contribution to the CFF upstream.
Fixes #33.