Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If path param is a directory, it is not passed to cf push #36

Open
sartan opened this issue Oct 4, 2017 · 1 comment
Open

If path param is a directory, it is not passed to cf push #36

sartan opened this issue Oct 4, 2017 · 1 comment

Comments

@sartan
Copy link

sartan commented Oct 4, 2017

I'm deploying a .net core app, specifying both the path and manifest parameters. As the documentation implies, I'm expecting the path in my pipeline to take precedence over the path in the manifest. However, in my case the path does not point to a single artifact (i.e., jar), but rather a directory with a bunch of dlls.

If I'm reading the code correctly, when path is a directory, we navigate into that directory and push from there, but never specify the -p flag. Therefore, the pipeline attempts to use the path in the manifest, which is not the desired behavior.

https://github.com/concourse/cf-resource/blob/783280d98c69b0de44eb8678aef14b91542c2353/out/cloud_foundry.go#L47-L60

relevant snippet of pipeline.yml:

jobs:
- name: build-and-deploy
  plan:
  - get: my-app
    trigger: true
  - task: build and test
    file: my-app/ci/build.yml
  - put: deploy
    params:
      manifest: my-app/manifest.yml
      path: build-output # <-- the built dlls are placed here

manifest.yml :

---
applications:
- name: my-app
  path: src/MyApp/bin/Release/netcoreapp1.1/publish/
  random-route: true
@sartan sartan changed the title Directory in the path parameter is not passed to cf push If path param is a directory, it is passed not to cf push Oct 5, 2017
@sartan sartan changed the title If path param is a directory, it is passed not to cf push If path param is a directory, it is not passed to cf push Oct 5, 2017
@philandstuff
Copy link

It looks like this was fixed 9 months ago in e07c4c5 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants