From 11f5686bb391f84b007d87b49d846f18c5372329 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 7 Apr 2019 00:36:45 -0400 Subject: [PATCH 1/3] spelling: enhancement --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f674b50..914c9cd 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,7 +22,7 @@ Feature Request Please search the issue list first to see if your feature has already been requested. All features are tagged with the tag `enhancement`. If there already -is an enchancement ticket, you can vote on it by putting in a +/-1 comment. If +is an enhancement ticket, you can vote on it by putting in a +/-1 comment. If you cannot find the `enhancement` you are looking for, you can open a new issue. Please prefix the subject line with **[Feature Request]** so your issue will From bc428a5229abf1879a05d96b8ad8a9f3e1ac6ca2 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 7 Apr 2019 00:37:22 -0400 Subject: [PATCH 2/3] spelling: github --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 914c9cd..cd5c615 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -107,7 +107,7 @@ Documentation ============= If you make any changes to the documentation, since Backgrid.js uses -[Github Pages](http://pages.github.com), please do so in your `gh-pages` branch +[GitHub Pages](http://pages.github.com), please do so in your `gh-pages` branch and submit a pull request from that branch. If you change any Javascript comment documentation, you should rebuild the API From 41394cebe7549057dffe2e1ecea166e84a284f0b Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 7 Apr 2019 01:01:11 -0400 Subject: [PATCH 3/3] spelling: javascript --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cd5c615..e6a5bee 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -64,13 +64,13 @@ Code Style ========== If you are filing a pull request, you should follow the guidelines below: -Javascript +JavaScript ---------- Please be aware that Backgrid.js uses 2 spaces for indentation. This project has a [.jshintrc](.jshintrc) file defined, which is handy if you use [jshint](http://www.jshint.com). In general, you should follow the -[Google Javascript Style Guide](http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml). Backgrid.js's +[Google JavaScript Style Guide](http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml). Backgrid.js's code follows this coding style extremely closely, with 2 exceptions: - `else` should be on its own line instead of the same line of the close `}` of @@ -110,7 +110,7 @@ If you make any changes to the documentation, since Backgrid.js uses [GitHub Pages](http://pages.github.com), please do so in your `gh-pages` branch and submit a pull request from that branch. -If you change any Javascript comment documentation, you should rebuild the API +If you change any JavaScript comment documentation, you should rebuild the API document. There is also a Grunt task for this purpose, but make sure you have installed [JSDuck](https://github.com/senchalabs/jsduck) first.