Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that Pages assets already served from Tiered Cache #18518

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

irvinebroque
Copy link
Contributor

This line in the docs was confusing and made it sound like you couldn't benefit from Tiered Cache with Pages.

This line in the docs was confusing and made it sound like you couldn't benefit from Tiered Cache with Pages.
@irvinebroque irvinebroque marked this pull request as ready for review December 3, 2024 00:33
Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f328dca
Status: ✅  Deploy successful!
Preview URL: https://811c3c47.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://bib-tc-pages.cloudflare-docs-7ou.pages.dev

View logs

Copy link

github-actions bot commented Dec 3, 2024

@@ -30,7 +30,7 @@ In addition, adding caching to your custom domain may cause issues with [Pages r

However, there are some situations where [Cache Rules](/cache/how-to/cache-rules/) on your custom domain does make sense. For example, you may have easily cacheable locations for immutable assets, such as CSS or JS files with content hashes in their file names. Custom caching can help in this case, speeding up the user experience until the file (and associated filename) changes. Just make sure that your caching does not interfere with any redirects or Functions.

Please note that tiered caching is not supported for custom domains on Pages.
Please note that when you use Cloudflare Pages, the static assets that you upload as part of your Pages project are automatically served from [Tiered Cache](/cache/how-to/tiered-cache/) — you do not need to separately enable Tiered Cache for the custom domain that your Pages project runs on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please note that when you use Cloudflare Pages, the static assets that you upload as part of your Pages project are automatically served from [Tiered Cache](/cache/how-to/tiered-cache/) — you do not need to separately enable Tiered Cache for the custom domain that your Pages project runs on.
Note that when you use Cloudflare Pages, the static assets that you upload as part of your Pages project are automatically served from [Tiered Cache](/cache/how-to/tiered-cache/). You do not need to separately enable Tiered Cache for the custom domain that your Pages project runs on.

@irvinebroque irvinebroque merged commit 5fc650b into production Jan 7, 2025
8 checks passed
@irvinebroque irvinebroque deleted the bib/tc-pages branch January 7, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants