You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"A link in markdown will always 404 if it does not exist instead of using the 301 redirects set up.
We should:
make tests to ensure these links always exist
OR
design it so that they 301 appropriately
Example is The first link on the "Build A To-Do List With KV" page tries to link to
the "Workers KV" page"
It would be a nice to have to have broken links detected automatically (ignoring the MDX links). cloudflare/workers-docs#841
The text was updated successfully, but these errors were encountered:
They could help prevent many small regressions
They would give us the confidence to auto-merge dependency updates
Gatsby itself recommends and uses Cypress, which you can read more about here:
Does navigation work the way we expect (e.g. no unexpected 301s, URLs are rendered with/without trailing slashes)?
Ensure that every img element loads successfully
Ensure that every link in an article is navigable (i.e. does not result in 404)
??
What do folks think?
Are e2e tests worth the burden?
If we were to do this, would Cypress be a good choice, or should we investigate other options?"
Is this a good idea?
What do other documentation repos do?
What tool should we use?
Where should we integrate this in our pipeline, if we choose to do so?"
Explored CI spell-checking a few months ago and found the Rust Book implemented this using a bash script that leverages aspell. Here's the PR it was implemented in as reference:
"A link in markdown will always 404 if it does not exist instead of using the 301 redirects set up.
We should:
make tests to ensure these links always exist
OR
design it so that they 301 appropriately
Example is The first link on the "Build A To-Do List With KV" page tries to link to
the "Workers KV" page"
It would be a nice to have to have broken links detected automatically (ignoring the MDX links).
cloudflare/workers-docs#841
The text was updated successfully, but these errors were encountered: