Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to download native-toolchain code with git clone #65

Open
davidxdh opened this issue Jun 30, 2020 · 6 comments
Open

Failed to download native-toolchain code with git clone #65

davidxdh opened this issue Jun 30, 2020 · 6 comments
Assignees

Comments

@davidxdh
Copy link

The error message is as follows:

$ git clone https://github.com/cloudera/native-toolchain.git
Cloning into 'native-toolchain'...
remote: Enumerating objects: 145, done.
remote: Counting objects: 100% (145/145), done.
remote: Compressing objects: 100% (111/111), done.
remote: Total 2702 (delta 67), reused 104 (delta 29), pack-reused 2557
Receiving objects: 100% (2702/2702), 1.27 MiB | 206.00 KiB/s, done.
Resolving deltas: 100% (1541/1541), done.
error: invalid path 'source/thrift/thrift-0.9.0-patches/0006-Revert-Thrift-p5:IMPALA-3159-Add-SAN-Wildcard-SSL-cert-client-support-in-python.patch'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

@davidxdh davidxdh changed the title I failed to download native-toolchain code with git clone Failed to download native-toolchain code with git clone Jun 30, 2020
@timarmstrong
Copy link
Contributor

What OS are you running? Maybe the colon in the filename is making it unhappy.

@davidxdh
Copy link
Author

davidxdh commented Jul 1, 2020

My OS is windows. It's OK on linux.
Does git handle filenames by operating system?

@timarmstrong
Copy link
Contributor

I think the problem is likely that windows doesn't handle colons in filenames, so git cannot check out that file. If that's the case it's easy to fix.

@davidxdh can you try

git fetch https://github.com/timarmstrong/native-toolchain.git master && git checkout FETCH_HEAD

@davidxdh
Copy link
Author

davidxdh commented Jul 2, 2020

Thanks. @timarmstrong

There is another problem. When I downloaded toolchain and the corresponding kudu code(hash code is 84086fe), the kudu compilation was successful. However, if the OpenSSL version that kudu depends on is changed to 1.1.1 in CMakeLists.txt as follows:

set(OPENSSL_ROOT_DIR "/home/kudu/native-toolchain/build/openssl-1.1.1")
set(OPENSSL_INCLUDE_DIR "/home/kudu/native-toolchain/build/openssl-1.1.1/include")
set(OPENSSL_SSL_LIBRARY "/home/kudu/native-toolchain/build/openssl-1.1.1/lib")
set(OPENSSL_CRYPTO_LIBRARY "/home/kudu/native-toolchain/build/openssl-1.1.1/lib")
find_package(OpenSSL 1.1.1 REQUIRED)

The compilation error is as follows:

Scanning dependencies of target kudu_client_test_util
[ 84%] Building CXX object src/kudu/client/CMakeFiles/kudu_client_test_util.dir/client-test-util.cc.o
[ 84%] Linking CXX static library ../../../lib/libkudu_client_test_util.a
[ 84%] Built target kudu_client_test_util
[ 84%] Linking CXX static library ../../../lib/libconsensus.a
Scanning dependencies of target server_process
[ 84%] Built target consensus
/home/xudonghui/kudu/native-toolchain/build/openssl-1.1.1/lib: file not recognized: Is a directory
collect2: error: ld returned 1 exit status
make[2]: *** [lib/exported/libkudu_client.so.0.1.0] Error 1
make[1]: *** [src/kudu/client/CMakeFiles/kudu_client_exported.dir/all] Error 2

@timarmstrong
Copy link
Contributor

Hi David,
I'm not sure about that Kudu compilation error. If you're trying to compile Kudu on a different platform or with different dependencies, the Kudu project is probably a better place to ask - either their mailing list or slack channel -https://kudu.apache.org/community.html

I'll keep this issue open until https://gerrit.cloudera.org/#/c/16139/ is merged.

@timarmstrong timarmstrong self-assigned this Jul 2, 2020
@davidxdh
Copy link
Author

davidxdh commented Jul 6, 2020

Thank you.

cloudera-gerrit pushed a commit that referenced this issue Jul 8, 2020
Some OSes don't allow cloning the repo if it has a filename
with a colon on it.  See
#65
for context.

Change-Id: I731f9b818376fcc57f9e47a2bd1bc26ca0b41dc5
Reviewed-on: http://gerrit.cloudera.org:8080/16139
Reviewed-by: Laszlo Gaal <[email protected]>
Tested-by: Tim Armstrong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants