Dont wait on a disconnected follower #874
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to wait for a disconnected follower to be synced.
| rescue ex : IO::Error | ||
| Log.warn { "Follower disonnected: #{ex.message}" } | ||
| socket.close | ||
| ensure | ||
| follower.try &.close |
There was a problem hiding this comment.
shouldn't Follower#close close the socket?
There was a problem hiding this comment.
It will be done by the action loop once it's drained. But we should probably close the socket there is no lag or if we get a timeout waiting for the follower to sync. I guess we could add an ensure statement and always close the socket in #close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
While testing clustering stuff I noticed that the leader sometimes wait for a disconnected follower to be fully in sync. This PR prevents at least some of these cases.
HOW can this pull request be tested?
Manually run a cluster and stop follower in different stage. No "Waiting for follower to be in sync" should be logged.