Table#delete and Table#has_key? argument must be string #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In public methods `key` is typed as `String`, except for `delete` and `has_key?`. This will type `key` as `String` and adds deprecated method overloads that supports "any" key.
|
I'll try cover things with more explicit specs. |
carlhoerberg
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In public methods
keyis typed asString, except fordeleteandhas_key?. This will typekeyasStringand adds deprecated method overloads that supports "any" key.That any type was accepted as key in
deletecausedmerge!withNamedTupleto break, becausedeletedidn't delete old values because of a symbol-string comparison indeletealways was false.Since all methods except for
deleteandhas_key?typeskeytoStringit's reasonable to do it in them as well.