Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Sub-table memory corruption #14

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

viktorerlingsson
Copy link
Member

@viktorerlingsson viktorerlingsson commented Sep 21, 2023

Fixes a bug where nestling a Table in another Table (for example x-death headers) caused them to share memory, even though it was writeable. This caused corruption when re-assigning values. See the spec for replication.

Copy link
Member

@carlhoerberg carlhoerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

Copy link
Member

@spuun spuun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@viktorerlingsson viktorerlingsson merged commit 0e687df into main Sep 22, 2023
3 checks passed
@viktorerlingsson viktorerlingsson deleted the bugfix_sub-table_memory_corruption branch September 22, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants