Modified kubectl-applogs plusing file and crlogs.py file #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed "connections" parameter from the command "python /$KUBEPLUS_HOME/plugins/crlogs.py $canonicalKind $instance $namespace $kubeconfig" in kubectl-applogs plugin file. removed unnecessary code from crlogs.py file including the commented code and relation block for connections and composition.
|
@rahulkumar-choudhary Yes, let's remove the un-used functions. You can refer to the test_license_plugin (https://github.com/cloud-ark/kubeplus/blob/master/tests/tests.py#L89) The outline for the test will look as follow:
When creating an app instance, use a random name. We have been wanting to change our tests to use random names (check #1359). At least we should start doing this for new tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1372
Modified changes:
Removed
connectionsparameter from the commandpython /$KUBEPLUS_HOME/plugins/crlogs.py $canonicalKind $instance $namespace $kubeconfigin kubectl-applogs plugin file.Removed unnecessary code from
crlogs.pyfile including the commented code and relation block for connections and composition.To be modified:
Further to look into the clogs.py file.
clogs.pyfile contains two unused functions:-get_resources_compositionget_pods1As per my understanding, we are not using relation block for connections and composition so the function
get_resources_compositionis unnecessary. Also, the functionget_pods1is not being used from the beginning. I have crosschecked - these two functions are not being used in any other files.Please let me know on what should be done the these two functions. My suggestion would be - as we are not using these functions we shall remove it from the code base.