Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl app url is not able to correctly parse the Port number #1351

Open
devdattakulkarni opened this issue Aug 29, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@devdattakulkarni
Copy link
Contributor

When application instances are created with Service type as "LoadBalancer" or "NodePort", the 'kubectl app url' outputs URLs like the following:
http://192.168.49.2:-1

@devdattakulkarni devdattakulkarni added the bug Something isn't working label Aug 29, 2024
@devdattakulkarni
Copy link
Contributor Author

@rahulkumar-choudhary
You can take a look at this issue as part of looking into kubectl app url plugin.

@devdattakulkarni
Copy link
Contributor Author

devdattakulkarni commented Nov 22, 2024

First, we can get rid of "connections" parameter, similar to applogs.
Second, currently we are running get_resources_connections to first get all the resources and then we use that resources list to find out ingresses and services
(check: https://github.com/cloud-ark/kubeplus/blob/master/plugins/appurl.py#L137)
We can simplify this by implementing two separate methods (get_ingresses(custom_resource_instance)) and (get_services(custom_resource_instance)). These methods will take name of the custom_resource_instance as input and query for ingresses/services in the namespace corresponding to that cr_instance.
This change will also improve performance of the kubectl appurl plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant