Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"C-c ," not executing tests #11

Open
JvJ opened this issue Nov 4, 2015 · 5 comments
Open

"C-c ," not executing tests #11

JvJ opened this issue Nov 4, 2015 · 5 comments

Comments

@JvJ
Copy link

JvJ commented Nov 4, 2015

When attempting to execute tests on a namespace from expectations mode, I get the following error message:

expectations-eval: Symbol’s function definition is void: nrepl-send-string

Is there some prerequisite emacs configuration/package that is necessary to get this to work.

Nrepl is currently installed. Current emacs version: GNU Emacs 25.0.50.1 (x86_64-w64-mingw32) of 2015-09-06.

@edipofederle
Copy link

@JvJ I fork this repo and fix something, maybe works for you: https://github.com/edipofederle/expectations-mode

@Xylon2
Copy link

Xylon2 commented Mar 9, 2024

I believe nrepl-send-string is a function from older versions of cider. See this bug: clojure-emacs/cider#1887

So as far as I can tell this library doesn't work at-all right now. I'll see if I can figure out how to fix it.

@Xylon2
Copy link

Xylon2 commented Mar 9, 2024

Having looked into this, I noted this is broken in many ways:

  • breaking changes have happened in both cider and emacs itself in the past 10 years. for instance emacs no longer has lexical-let and cider nrepl-send-string-sync
  • this plugin is specifically designed for "OG" expectations and would need some changes to work with expectations.clojure.test
  • as mentioned in another ticket the installation method in the README is dead, and potentially a security issue since we don't know who owns that domain

@Xylon2
Copy link

Xylon2 commented Mar 9, 2024

I made merge request to at-least remove the broken installation method and make clear the condition of the project #18

@seancorfield
Copy link
Contributor

Perhaps it also needs to be made clear that this mode -- expectations-mode -- is for "classic" Expectations only and is not needed for the clojure.test-compatible version of Expectations (and should not be used for that)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants