Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing pull request message #83

Open
nvanheuverzwijn opened this issue Feb 12, 2016 · 3 comments
Open

Parsing pull request message #83

nvanheuverzwijn opened this issue Feb 12, 2016 · 3 comments

Comments

@nvanheuverzwijn
Copy link
Contributor

Is there any way clog-cli can parse a github PR commit message ? In our workflow, we do use feature/branch and are using PR only. When we merge the PR, we set the conventional commit message into the long commit message of the PR but clog fails to parse this part of the commit.

@kbknapp
Copy link
Member

kbknapp commented Feb 14, 2016

Only if that message is in the git history itself and the commit subject matches on of the clog triggers then yes. But If it's just the github comment in the PR it won't get picked up by clog.

The easiest way to ad that, is to either rebase the PR or just add a commit with that comment.

@nvanheuverzwijn
Copy link
Contributor Author

What I'm talking about is this kind of commit made by github PR:

commit a216f0deff6e2de2a91bf9d0e88f8f00544f3d33
Merge: cddc5e8 261d9ca
Author: Nicolas Vanheuverzwijn
Date:   Fri Feb 12 16:23:36 2016 -0500

    Merge pull request #12 from nvanheuverzwijn/feature/test  <<< shot commit message

    feat(Test): new test  <<< long commit message which can be on many lines

The long commit message does not seem to be parsed. But I think this might be intended on clog part? I may be mistaken. I'm using clog v0.9.1

@kbknapp
Copy link
Member

kbknapp commented Feb 15, 2016

Ah ok, I understand, let me play with it a bit and see what I can figure out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants