Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit CLJ_WATSON_* env vars to known properties? #110

Open
seancorfield opened this issue Aug 19, 2024 · 1 comment
Open

Limit CLJ_WATSON_* env vars to known properties? #110

seancorfield opened this issue Aug 19, 2024 · 1 comment

Comments

@seancorfield
Copy link
Contributor

As implemented, the CLJ_WATSON_* env var machinery could be used to set any Java system property that isn't already specified on the command-line.

Should we limit this to only properties that DC core knows about? That would mean reading dependencycheck.properties from the classpath and using those core properties as a check list.

Concern: not all core properties need be listed in that file -- I suspect some optional ones are omitted so it would be impossible to override those via env vars if we added this check. Does that matter?

@lread
Copy link
Contributor

lread commented Aug 20, 2024

Concern: not all core properties need be listed in that file -- I suspect some optional ones are omitted so it would be impossible to override those via env vars if we added this check. Does that matter?

Good question, but I don't think it matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants