Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No #8

Open
mikhail-khodorovskiy opened this issue Jul 24, 2023 · 1 comment
Open

No #8

mikhail-khodorovskiy opened this issue Jul 24, 2023 · 1 comment

Comments

@mikhail-khodorovskiy
Copy link

No rules seem to be used when the default rules database is used.

Action setup:

      - name: Scan
        uses: clj-holmes/clj-holmes-action@main
        with:
     #     rules-repository: 'git://clj-holmes/clj-holmes-rules#main'
          output-type: 'sarif'
          output-file: 'clj-holmes-results.sarif'
          fail-on-result: 'false'
          verbose: 'true'
        env:
          GITHUB_TOKEN: ${{ secrets.TOKEN }}

The results don't show the rules used and as a result the are no violations found.

{"$schema":"https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.5.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"clj-holmes","informationUri":"https://github.com/clj-holmes/clj-holmes","version":"1.4.3","rules":[]}},"results":[]}]}
@jvaliente-ut
Copy link

I was having the same issue, so I install clj-holmes manually for debugging it. When scanning it, a parsing error arises, causing clj-holmes not triggering anything (it would be useful failing the scan step if parsing issues are detected).

Additionally, the sarif file rules field only contains the rules detected in your code. In other words, if the rules provided doesn't match anything in your code then nothing will be shown in the rules field (I intentionally introduced https://github.com/clj-holmes/clj-holmes-rules/blob/main/security/clojure-weak-ssl-context/weak_context.clj to test it out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants