Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review extensibility of Value Sets #214

Open
cbizon opened this issue Apr 24, 2018 · 3 comments
Open

Review extensibility of Value Sets #214

cbizon opened this issue Apr 24, 2018 · 3 comments

Comments

@cbizon
Copy link
Contributor

cbizon commented Apr 24, 2018

Only a few of our value sets are fixed. Is that correct? I am writing some validation for values, but it may not be worth it...

@larrybabb
Copy link
Contributor

it really is an exceptional situation when it is fixed. But when it is it is pretty important. I've noticed this in FHIR as well. Essentially fixed valuesets are usually control data that is vital to the meta data or infrastructure or standard itself. but it is not necessarily always the case.

@cbizon
Copy link
Contributor Author

cbizon commented Apr 24, 2018

I agree with that, but I think we might have swung a little too far that direction. For example:

{
  "id": "SEPIO-CG:65110",
  "type": "ValueSet",
  "description": "Denotes whether the collected evidence is sufficient to meet a specified criteria or not",
  "conceptListExtensibility": {
    "id": "SEPIO-CG:02102",
    "label": "extensible"
  },
  "conceptType": "CriterionEvaluation",
  "concept": [
    {
      "id": "SEPIO:0000223",
      "label": "Met"
    },
    {
      "id": "SEPIO:0000224",
      "label": "Not Met"
    }
  ],

I'd say that one should be fixed.

@larrybabb
Copy link
Contributor

good catch. I trust your judgement. Please fix the ones that you feel should be fixed. In practice we will learn if we need to make things more flexible. I suppose we should err on the side of fixed if we cannot foresee any reasonable reason to make it extensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants