Changing VM resolution detaches game from the main window

[vadosnaprimer]

Changing it back does the same.

[clementgallet]

I'm not entirely sure from your screenshots: natively, does changing the VM resolution changes the resolution of the pcem window (in pixels)? If that is the case, the current behaviour of libtas is not exactly a bug, but the consequence of something that we don't really want when TASing: an external factor (unrecorded in the movie) that changes the state of the game. In this situation, do we want to prevent the game window from resizing?

If the game window resolution did not change, then that is an issue indeed. If you close the detached game window, which should resize the top-level window to the resolution that libtas has saved, does the emulator behave and displays correctly?

[vadosnaprimer]

I run libTAS in a Linux VM, specifically VMWare. I'm not changing the resolution of the emulated machine in PCem, only the resolution of the VMWare display.

PCem's resolution stays the same, and as you can see on the second screenshot, the image of the detached "game" is not pixel perfect, while on the first screenshot it is. libTAS thinks I detached PCem window from libTAS window, and for some reason it also makes the detached PCem window smaller.

After I close the detached window, proper behavior restores, as if it never got detached.

[clementgallet]

When you close the detached game window, is the top window resized to the size of what the game window was, or does the top level not change size?

Game window is detached when libTAS detects that the user manually resized the game window. That is what we want to achieve, this can be triggered by for example some window managers that controls the position and size of windows.

[vadosnaprimer]

When you close the detached game window, is the top window resized to the size of what the game window was, or does the top level not change size?

The top window resolution doesn't change at any point.