Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move workflow scripts to separate file to allow for testing #86

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

elrayle
Copy link
Collaborator

@elrayle elrayle commented Jul 8, 2024

Fixes clearlydefined/service#1155

Description

The reusable deploy workflows include scripts to perform some of the steps. To improve maintainability, these were extracted out to the scripts/app-workflows directory with tests in tests/scripts/app-workflows. This change also updates the version of the workflows to v2.0.0 to reflect the changes.

This also adds a requirement to upload the package-lock.json file to allow get-version to access the version defined in that file.

@elrayle elrayle marked this pull request as draft July 11, 2024 04:00
@elrayle elrayle force-pushed the elr/deploy-scripts branch from f2eb475 to 54d9f4b Compare July 11, 2024 05:08
@elrayle elrayle marked this pull request as ready for review July 11, 2024 11:47
@elrayle elrayle force-pushed the elr/deploy-scripts branch 5 times, most recently from 37018e7 to a23aaed Compare July 11, 2024 19:28
Copy link
Collaborator

@qtomlinson qtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including a lot of test cases!

@elrayle elrayle merged commit 72524e9 into main Jul 11, 2024
2 checks passed
@elrayle elrayle deleted the elr/deploy-scripts branch July 11, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEV deploy always fails
2 participants