Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize fixtures for autoloading #73

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

qtomlinson
Copy link
Collaborator

@qtomlinson qtomlinson commented Apr 24, 2024

  • Group fixtures by endpoints. This ensures that the json response format is consistent within the folder, allowing for coordinates parsing.
  • Move loading of fixtures closer to the code that depends on fixtures.
  • Add documentation
    This is to incorporate the suggestion from review comments

Group fixtures by endpoints.  This ensures that the json response format is consistent within the folder, allowing for coordinates parsing.
@qtomlinson qtomlinson marked this pull request as ready for review April 24, 2024 17:14
@qtomlinson qtomlinson requested a review from lumaxis April 24, 2024 17:14
@lumaxis
Copy link
Contributor

lumaxis commented Apr 29, 2024

I like this! 😄 I'd be curious to hear though if e.g. @elrayle might think that this is too "magic"? Imo a question of preference 😅

@lumaxis lumaxis requested a review from elrayle May 14, 2024 13:26
Copy link
Contributor

@lumaxis lumaxis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me 🙂

Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The level of magic is just right. 🚢

@lumaxis lumaxis merged commit 862c2af into clearlydefined:main Jun 12, 2024
1 check passed
@qtomlinson qtomlinson deleted the qt/nock branch September 24, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants