Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert config changes made for a deploy if the deploy fails #69

Open
elrayle opened this issue Apr 11, 2024 · 0 comments
Open

revert config changes made for a deploy if the deploy fails #69

elrayle opened this issue Apr 11, 2024 · 0 comments
Assignees
@elrayle
Labels
bug Something isn't working

Comments

@elrayle
Copy link
Collaborator

elrayle commented Apr 11, 2024

Description

In the dev and prod deploy scripts, configs are set before running the deploy. This means that the config values in Azure are updated even if the deploy fails.

Possible Fix

Exploration for fixing this...

  • confirm whether configs are or aren't reverted if the deploy fails
  • if not reverted, save configs in the action workflow before updating them
  • if the deploy fails, revert the configs in the action workflow
@elrayle elrayle added the bug Something isn't working label Apr 11, 2024
@elrayle elrayle self-assigned this Apr 11, 2024
@elrayle elrayle mentioned this issue Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elrayle elrayle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elrayle