Triage Service exceptions: validation error (/origins)

[grvillic]

The listed users and repositories cannot be searched either because the resources do not exist or you do not have permission to view them.

It is likely that this is not something we want to be logging as an exception, but I am not certain what is the expected outcome.

requests 
| where resultCode == 500
| join (
 exceptions
 ) on operation_Id 
| extend pathPrefix = extract("/(\\w+)", 0, tostring(operation_Name))
| summarize count() by  outerMessage, pathPrefix
| order by count_  desc 
| where outerMessage contains "Validation Failed" 

[jeffmendoza]

Looks like we are getting bad requests to this route:
https://github.com/clearlydefined/service/blob/master/routes/originGitHub.js#L56

The request is "GET /origins/github/https:/Github.com/ " It is suppsoed to be "get /origins/github/:user/:repo"

Either/or we should:

• Validate input before turning around and sending the search request to GitHub. In that case this is a bug for the service
• Catch and log exceptions from the GitHub client, but do not throw. In that case this is a "silence" issue.

In either case we should probably return a 400 to the caller.