-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
I think the login was removing the need for publish-profile in the deploy. This should test that theory.
- Loading branch information
Showing
1 changed file
with
31 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,38 +53,38 @@ jobs: | |
runs-on: ubuntu-latest | ||
needs: check-deployable | ||
steps: | ||
- name: Login for Azure cli commands | ||
uses: azure/[email protected] | ||
with: | ||
creds: ${{ secrets.AZURE_CREDENTIALS }} | ||
# - name: Login for Azure cli commands | ||
# uses: azure/[email protected] | ||
# with: | ||
# creds: ${{ secrets.AZURE_CREDENTIALS }} | ||
|
||
- name: Set DOCKER configs in Azure web app | ||
uses: azure/[email protected] | ||
with: | ||
app-name: ${{ inputs.azure-webapp-name }} | ||
app-settings-json: | | ||
[ | ||
{ | ||
"name": "DOCKER_CUSTOM_IMAGE_NAME", | ||
"value": "${{ inputs.image-name-with-tag }}", | ||
"slotSetting": false | ||
}, | ||
{ | ||
"name": "DOCKER_REGISTRY_SERVER_URL", | ||
"value": "https://ghcr.io", | ||
"slotSetting": false | ||
}, | ||
{ | ||
"name": "APP_VERSION", | ||
"value": "${{ inputs.application-version }}", | ||
"slotSetting": false | ||
}, | ||
{ | ||
"name": "BUILD_SHA", | ||
"value": "${{ github.sha }}", | ||
"slotSetting": false | ||
} | ||
] | ||
# - name: Set DOCKER configs in Azure web app | ||
# uses: azure/[email protected] | ||
# with: | ||
# app-name: ${{ inputs.azure-webapp-name }} | ||
# app-settings-json: | | ||
# [ | ||
# { | ||
# "name": "DOCKER_CUSTOM_IMAGE_NAME", | ||
# "value": "${{ inputs.image-name-with-tag }}", | ||
# "slotSetting": false | ||
# }, | ||
# { | ||
# "name": "DOCKER_REGISTRY_SERVER_URL", | ||
# "value": "https://ghcr.io", | ||
# "slotSetting": false | ||
# }, | ||
# { | ||
# "name": "APP_VERSION", | ||
# "value": "${{ inputs.application-version }}", | ||
# "slotSetting": false | ||
# }, | ||
# { | ||
# "name": "BUILD_SHA", | ||
# "value": "${{ github.sha }}", | ||
# "slotSetting": false | ||
# } | ||
# ] | ||
|
||
# v3.0.1 passes when AZURE_WEBAPP_PUBLISH_PROFILE_PROD isn't set, but should fail. | ||
# Added secret check above to ensure it is set. | ||
|