Skip to content

Commit

Permalink
tmp remove login to azure
Browse files Browse the repository at this point in the history
I think the login was removing the need for publish-profile in the deploy.  This should test that theory.
  • Loading branch information
elrayle committed Apr 16, 2024
1 parent 0e59da5 commit 46f78f9
Showing 1 changed file with 31 additions and 31 deletions.
62 changes: 31 additions & 31 deletions .github/workflows/app-deploy-to-azure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,38 +53,38 @@ jobs:
runs-on: ubuntu-latest
needs: check-deployable
steps:
- name: Login for Azure cli commands
uses: azure/[email protected]
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
# - name: Login for Azure cli commands
# uses: azure/[email protected]
# with:
# creds: ${{ secrets.AZURE_CREDENTIALS }}

- name: Set DOCKER configs in Azure web app
uses: azure/[email protected]
with:
app-name: ${{ inputs.azure-webapp-name }}
app-settings-json: |
[
{
"name": "DOCKER_CUSTOM_IMAGE_NAME",
"value": "${{ inputs.image-name-with-tag }}",
"slotSetting": false
},
{
"name": "DOCKER_REGISTRY_SERVER_URL",
"value": "https://ghcr.io",
"slotSetting": false
},
{
"name": "APP_VERSION",
"value": "${{ inputs.application-version }}",
"slotSetting": false
},
{
"name": "BUILD_SHA",
"value": "${{ github.sha }}",
"slotSetting": false
}
]
# - name: Set DOCKER configs in Azure web app
# uses: azure/[email protected]
# with:
# app-name: ${{ inputs.azure-webapp-name }}
# app-settings-json: |
# [
# {
# "name": "DOCKER_CUSTOM_IMAGE_NAME",
# "value": "${{ inputs.image-name-with-tag }}",
# "slotSetting": false
# },
# {
# "name": "DOCKER_REGISTRY_SERVER_URL",
# "value": "https://ghcr.io",
# "slotSetting": false
# },
# {
# "name": "APP_VERSION",
# "value": "${{ inputs.application-version }}",
# "slotSetting": false
# },
# {
# "name": "BUILD_SHA",
# "value": "${{ github.sha }}",
# "slotSetting": false
# }
# ]

# v3.0.1 passes when AZURE_WEBAPP_PUBLISH_PROFILE_PROD isn't set, but should fail.
# Added secret check above to ensure it is set.
Expand Down

0 comments on commit 46f78f9

Please sign in to comment.