Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ENOENT error during harvesting Conda components #575

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix ENOENT error during harvesting Conda components #575

merged 1 commit into from
May 8, 2024

Conversation

qtomlinson
Copy link
Collaborator

@qtomlinson qtomlinson commented May 7, 2024 •
edited
Loading

This is to fix ENONET exception encountered during testing on dev deployment. It follows the same approach taken in debianFetch.js.

@qtomlinson qtomlinson marked this pull request as ready for review May 7, 2024 17:27
@qtomlinson qtomlinson requested a review from lumaxis May 7, 2024 17:27
@qtomlinson qtomlinson mentioned this pull request May 7, 2024
Closed
@qtomlinson qtomlinson requested a review from elrayle May 7, 2024 17:31
@qtomlinson qtomlinson marked this pull request as draft May 7, 2024 20:19
@qtomlinson qtomlinson marked this pull request as ready for review May 7, 2024 21:42
lumaxis
lumaxis approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@lumaxis lumaxis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder if we can do anything about either the env setup or the code to make this mechanism more resilient in the future so other contributors don't run into this discrepancy as easily 🤔

@elrayle
Copy link
Collaborator

elrayle commented May 8, 2024

@lumaxis That refactor sounds like a great idea!

@elrayle
Copy link
Collaborator

elrayle commented May 8, 2024

Thanks @qtomlinson for making this happen.

@elrayle elrayle merged commit cdd518c into clearlydefined:master May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumaxis lumaxis lumaxis approved these changes

@elrayle elrayle Awaiting requested review from elrayle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Conda components harvest
3 participants
@qtomlinson @elrayle @lumaxis