Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning About Interger Underflow In Solidity >=8 #194

Open
caiosabarros opened this issue Apr 19, 2022 · 0 comments
Open

Warning About Interger Underflow In Solidity >=8 #194

caiosabarros opened this issue Apr 19, 2022 · 0 comments

Comments

@caiosabarros
Copy link

Well, I was not able to find resources for knowing more about this, so I guess this is the best place.

I've encountered two high severity warnings on a specific contract I am developing for production. The warning is about integer underflow, even though it seems this issue is gone on versions of Solidity that are higher than and including 0.8.0.

So, I do not know if this is an issue with the code itself or if it is some issue related to solidity versioning on KARL.

Any guidance on that would be really helpful. Also, I have not found documentation for interpreting the errors - and I love that they are shown in the terminal, but some of them seem very abstract. For example, in one of the images below, there is a warning about an integer underflow in a string public name variable that receives a value in the constructor of the contract and does nothing else rather than being a view function so that NFT marketplaces can call on it to know the name of the collection. The other function with an issue is the setApprovalForAll - with no changes from the ERC1155 standard.

image

image

Thank you guys for this amazing masterpiece and wait on your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant