Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coriolis parameters should be more flexible #548

Open
rjleveque opened this issue Apr 24, 2023 · 1 comment
Open

Coriolis parameters should be more flexible #548

rjleveque opened this issue Apr 24, 2023 · 1 comment

Comments

@rjleveque
Copy link
Member

The Coriolis parameter omega is set in geoclaw_module.f90 based on the rotational velocity of the earth. We should allow this parameter to be specified in setrun.py like gravity and earth_radius are, to make it easier to change to different conditions (e.g. for modeling tsunamis on Mars, as requested by a user).

Also note that the radius of the earth is effectively hardwired into the beta-plane approximation when icoord_system == 1 but doesn't need to be. The factor 111d3 appearing in the code is 2*pi*earth_radius/360 in units of meters / degree latitude, so it seems like we should replace

theta = y / 111d3 * DEG2RAD + theta_0

by

theta = y/earth_radius + theta_0
@mandli
Copy link
Member

mandli commented Apr 27, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants