Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.2 doesn't have a Counter instance for Maybe a #2867

Open
gergoerdi opened this issue Jan 4, 2025 · 3 comments
Open

1.8.2 doesn't have a Counter instance for Maybe a #2867

gergoerdi opened this issue Jan 4, 2025 · 3 comments

Comments

@gergoerdi
Copy link
Contributor

Is there a good reason 1.8.2 doesn't contain the Counter a => Counter (Maybe a) instance? I use that in my Sudoku solver and my stream formatter and would love to use a stable release of Clash for a paper I'm writing on them.

@christiaanb
Copy link
Member

christiaanb commented Jan 4, 2025

It seems #2692 was not labeled as backport-1.8

@christiaanb
Copy link
Member

I guess it could have had a backport-1.8 label if I look at the PVP:

Non-breaking change. Otherwise, if only new bindings, types, classes, non-orphan instances or modules (but see below) were added to the interface, then A.B MAY remain the same but the new C MUST be greater than the old C. Note that modifying imports or depending on a newer version of another package may cause extra non-orphan instances to be exported and thus force a minor version change.

@DigitalBrains1
Copy link
Member

My first instinct is to only backport fixes for something (not just bugs, also documentation and more stuff). Ideally I suppose we'd raise the issue ourselves on external PR's and ask "how soon would you like to have this", but Cat knows I'm not ideal! So it definitely helps if you give us a nudge in the right direction and ask for a backport!

We can just do another 1.8.3 soon. It's not like we'd run out of numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants