-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename failed to apply edits. #726
Comments
Are you able to share a complete code example that reproduces the issue? |
Reproducer just dropped. https://github.com/raldone01/clangd_bug_refactor_failed_to_apply_edits An arm toolchain is required. It happens with vars used in multiple files. I recommend trying to rename vars in |
I checked out the mentioned repo and tried some renames including the one shown in the issue description, and it's working for me. Taking a closer look at your logs, I see that the response to the
I do see something unusual there: the file
So, I suspect this is a Windows-specific issue related to the filesystem being case-insensitive. |
While you didn't show your A workaround that has worked for other users encountering similar issues has been to change the |
Actually it looks like the exact same issue as #687 |
Duplicate of #687 |
A simple solution could be to run a normalize path on the paths in the right places. The performance impact should be negligible. |
Or just run to upper or to lower on the paths on windows platforms since they are case insensitve anyways. |
A solution along those lines is tracked in clangd/clangd#108. Contributions to a fix of that issue are definitely welcome. |
Rename with
F2
fails with rename failed to apply edits.The preview of the rename is correct.
The popup on the bottom right only pops up when I click apply.
Logs
I set the logs to verbose.
When renaming, there is no indication of any error.
System information
Clangd version (from the log, or
clangd --version
):18.1.3
clangd extension version:
v0.1.31
Operating system:
windows11
Full log:
The text was updated successfully, but these errors were encountered: