Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The design of the website is not compliant with the rule 2.1.2 #23

Open
kuba-orlik opened this issue Jun 22, 2016 · 6 comments · May be fixed by #39
Open

The design of the website is not compliant with the rule 2.1.2 #23

kuba-orlik opened this issue Jun 22, 2016 · 6 comments · May be fixed by #39

Comments

@kuba-orlik
Copy link

Rule 2.1.2 says that the measure for one-column text should be 45-75. The measure on that very page as displayed on my PC is well above 90...

@kuba-orlik kuba-orlik changed the title The deisng of the website is not compliant with the rule 2.1.2 The deisgn of the website is not compliant with the rule 2.1.2 Nov 20, 2017
@kuba-orlik kuba-orlik changed the title The deisgn of the website is not compliant with the rule 2.1.2 The design of the website is not compliant with the rule 2.1.2 Nov 20, 2017
@Paul-Browne
Copy link

I count 120 on my full HD monitor 😆

@clagnut
Copy link
Owner

clagnut commented Jun 26, 2018

Back when monitors were far smaller (when this was originally designed), this was fine. Please feel free fork, fix for modern monitors, and request pull. The beauty of open source.

@bakert
Copy link
Contributor

bakert commented Oct 29, 2018

I tried to fix this by simply adding max-width: 30em to #main but of course it's not that simple.

Because the other widths are mostly in percentages a strange thing happens to the out-dented numeric part of the chapter heading:

screen shot 2018-10-28 at 17 25 54

(As well as leaving a big gap to the right-hand side content.)

This actually happens at very narrow widths even in the current design:

screen shot 2018-10-28 at 17 25 31

but it only shows up at those very narrow widths.

I wonder if a general effort to switch from percentages to ems/rems would be worthwhile or if there's something simpler we could do.

@jamespatrickgibson
Copy link

jamespatrickgibson commented Mar 31, 2020

The browser support for measure using the ch unit (character) is very wide, perhaps set all the classes for paragraph copy to max-width: 65ch; or whatever measure seems reasonable for the body copy size.

Hope that helps!

@clagnut
Copy link
Owner

clagnut commented Apr 1, 2020

The browser support for measure using the ch unit (character) is very wide, perhaps set all the classes for paragraph copy to max-width: 65ch; or whatever measure seems reasonable for the body copy size.

Thanks - feel free to fork, makes changes and submit.

@bakert
Copy link
Contributor

bakert commented Nov 23, 2020

I put up #39 for this which uses 66ch as the width for .main p. It still has some of the issues I describe above at high and low widths but I think it's better than what we have now which, as noted by here, breaks our own rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants