Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason for not using semantic versioning for containers? #393

Open
davralin opened this issue May 26, 2024 · 4 comments
Open

Any reason for not using semantic versioning for containers? #393

davralin opened this issue May 26, 2024 · 4 comments

Comments

@davralin
Copy link

Is there any reason the containers also have a semantic versioning tag?

I see there are versioned releases, which also follow semantic versioning, so I assume there is some form of relase-process.

Could that be expanded to also create tagged containers, in addition to the normal latest-tags?

@claabs
Copy link
Owner

claabs commented May 26, 2024

Mostly because this project depends on the live state of the Epic Games systems, so an old version will usually just not work. I just use semver to indicate any breaking changes in config or access pattern, or any new major features.

@davralin
Copy link
Author

I (and many others in the k8s-at-home-community) track container updates in a monorepo with renovate, that picked up the updated digest for a new :latest-container, but didn't pick up that the release actually had a "breaking" change.

The upgrade did go just fine, but it was merely a concidence because I didn't know the app switched to a 5.0-release.

Would you accept a PR that implemented tags on a release, while still maintaining the latest tag as-is?

@claabs
Copy link
Owner

claabs commented May 30, 2024

Yeah, I'd accept a PR if you're willing. Probably best to pull the version number from the package.json and tag with only the major version if that works with renovate. If not, the full semver would be fine as well. So ghcr.io/claabs/epicgames-freegames-node:5 and ghcr.io/claabs/epicgames-freegames-node:5-debian for example.

@Madic-
Copy link

Madic- commented May 30, 2024

Alternatively use a pinned digest image config in your kubernetes deployment.

Instead of

ghcr.io/claabs/epicgames-freegames-node:latest

use

ghcr.io/claabs/epicgames-freegames-node:latest@sha256:1a04e164fce5ca1da99dd6b6664f6ffe1bc67b5e711979bab21411eb404defa4

For more information about container digest updating with renovate see https://docs.renovatebot.com/docker/#digest-updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants