-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallible .load() #35
Comments
is |
When implementing I feel we probably need another type |
currently, in case of DB fail, return an empty map, like this test https://github.com/cksac/dataloader-rs/blob/master/tests/cached.rs#L177 However, it will only return error (key not found) without the root cause. But I think it should be sufficient for most cases. |
shouldn't .load() return
Result<HashMap<_, _>>
rather than just the hashmap itself? this forces me to panic on failed db request...The text was updated successfully, but these errors were encountered: