Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with demo npm-multiroot-react when using minimap plugin #548

Open
NikoEscobar opened this issue Oct 18, 2024 · 2 comments
Open

Issue with demo npm-multiroot-react when using minimap plugin #548

NikoEscobar opened this issue Oct 18, 2024 · 2 comments

Comments

@NikoEscobar
Copy link

Description:
While testing the minimap plugin in the npm-multiroot-react demo, I added the plugin to the editor config and set the element ID. However, I encountered an error, and all editors failed to load.

Steps to Reproduce:

  1. Add the minimap plugin to editor config.
  2. Set the container on the minimap config.
  3. Run the demo.

Question:
Does the multi-root editor support the minimap plugin? Is there a missing configuration, or does the plugin need an update for multi-root support?

Attachments:

  • Screenshot of the error
    Image
@Witoso
Copy link
Member

Witoso commented Oct 21, 2024

does the plugin need an update for multi-root support?

Most likely this is the case, and the Minimap didn't get multiroot support. Do you remember @scofalik?

@NikoEscobar
Copy link
Author

@Witoso
Minimap currently doesn't support the multi-root editor.

https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-minimap/src/minimap.ts#L88

I've implemented a fix, but I'm uncertain about its overall impact because I'm unable to run the automated tests in my environment—Karma is throwing errors on the CKEditor5 test script, and I can't look into it at the moment.

To provide a better solution, I need guidance on detecting multi-root usage and dynamically changing the rootName based on the editor's focus.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants