Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a firefox / chrome addon and add this to the browser dev tools #54

Open
skurfuerst opened this issue Jun 15, 2019 · 2 comments
Open
Labels
squad:core Issue to be handled by the Core team. status:discussion

Comments

@skurfuerst
Copy link
Contributor

skurfuerst commented Jun 15, 2019

Hey,

WDYT about packaging this into a Chrome/Firefox web extension? IMHO this would be even better than having to integrate it manually in e.g. wordpress, Neos, Drupal, .....

See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Extending_the_developer_tools

All the best,
Sebastian

@oleq
Copy link
Member

oleq commented Jun 15, 2019

Hi, @skurfuerst!

Yes, we considered implementing native browser extension and, certainly, this approach has its advantages. But the list of drawbacks is, unfortunately, way longer:

  • Current approach is really cross-browser. It works in Safari, iOS, Edge, and any other modern web browser. If we went with the native extension, we'd most likely be limited to Firefox and Chrome (and Chromium clones like Opera maybe?).
  • Current approach allows you to run older versions of the inspector with older releases of CKEditor 5 easily. CKEditor 5 API changes every now and then and some developers must stick to older versions in their projects (plenty of reasons) and they need a working inspector too. They'd need to manually install earlier versions of the extension, which feels like a PITA especially if they use different CKEditor versions in different projects (context switching).
  • ATM we showcase the inspector in our online documentation without people installing anything. It works out of the box and developers can play and learn more about the editor.
  • What we have ATM is cheap to maintain. If we went with native extensions we'd need to react to browser extension API changes quickly so the extension does not get deprecated etc..

@skurfuerst
Copy link
Contributor Author

Hey @oleq,

thanks for your detailed feedback! IMHO all your points totally make sense - I would have proposed to additionally take the current code and wrap it in a native extension.

However, I totally see that's quite some work, for questionable benefit. For Neos, I've just created a package which encapsulates the inspector; so people can easily use it for us :)

All the best, and keep up the great work,
Sebastian

@mlewand mlewand added this to the unknown milestone Sep 16, 2019
@Reinmar Reinmar added squad:ux and removed squad:dx labels Sep 9, 2021
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:ux labels Sep 27, 2021
@pomek pomek removed this from the unknown milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:core Issue to be handled by the Core team. status:discussion
Projects
None yet
Development

No branches or pull requests

6 participants