Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the RPC method test_tx_pool_accept in [email protected] #703

Open
homura opened this issue Jun 4, 2024 · 3 comments
Open

Support the RPC method test_tx_pool_accept in [email protected] #703

homura opened this issue Jun 4, 2024 · 3 comments
Assignees
Milestone

Comments

@homura
Copy link
Collaborator

homura commented Jun 4, 2024

nervosnetwork/ckb#4433

@homura
Copy link
Collaborator Author

homura commented Jun 26, 2024

We'll update the include_tx_pool first

The new include_tx_pool parameter in the get_live_cell method appears to be a game-changer for the current CellCollector. Developers no longer need to keep track of used cells on the client side. It may be beneficial for Lumos to update or rewrite the TransactionManager using the new include_tx_pool parameter for improved reliability

I found that I was wrong since the CellCollector uses the API get_cells instead of get_live_cells only.

@homura
Copy link
Collaborator Author

homura commented Jul 23, 2024

The test_tx_pool_accept has been released in https://github.com/nervosnetwork/ckb/releases/tag/v0.116.0-rc2

@homura homura changed the title Support the RPC method test_tx_pool_accept in [email protected] Support the RPC method test_tx_pool_accept in [email protected] Jul 23, 2024
@homura homura added this to Lumos Jul 23, 2024
@homura homura added this to the 0.24.0 milestone Jul 23, 2024
@homura homura moved this to 🔎 Code Review in Lumos Jul 23, 2024
@homura homura self-assigned this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Code Review
Development

No branches or pull requests

2 participants