Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social links block isn't updating when 'Light' theme is selected #448

Closed
fionamorrison23 opened this issue Dec 26, 2024 · 1 comment
Closed
Labels
Type: Defect Issue is a defect

Comments

@fionamorrison23
Copy link
Collaborator

Summary

When trying to update the Social links block to the 'Light' theme, the colour used on the icon is not updating.

Steps to reproduce

Assuming the Social links block is currently set to Dark:
dark-inline-stacked-dsk

  1. Go to Content > Blocks
  2. Find the Social links block and select 'Edit'
  3. Select Light in the Theme settings
  4. Save the change

Observed outcome

The colour of the icons don't update. They remain --ct-color-dark-interaction-background.
This means they will not be visually accessible and therefore will not pass AA WCAG.

Expected outcome

Icon colour should update to the Dark theme, presume that should be --ct-color-light-interaction-background.
Screenshot 2024-12-27 at 8 51 49 am

@fionamorrison23 fionamorrison23 added the Type: Defect Issue is a defect label Dec 26, 2024
@github-project-automation github-project-automation bot moved this to Todo in UI Kit Dec 26, 2024
@fionamorrison23 fionamorrison23 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in UI Kit Dec 26, 2024
@fionamorrison23
Copy link
Collaborator Author

Tested again, working as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Defect Issue is a defect
Projects
Status: Done
Development

No branches or pull requests

1 participant