Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary navigation - Inline and Drawer styles are broken #447

Open
fionamorrison23 opened this issue Dec 24, 2024 · 0 comments
Open

Primary navigation - Inline and Drawer styles are broken #447

fionamorrison23 opened this issue Dec 24, 2024 · 0 comments
Labels
Type: Defect Issue is a defect

Comments

@fionamorrison23
Copy link
Collaborator

fionamorrison23 commented Dec 24, 2024

Summary

The 'None' and 'Dropdown' styles for the Primary navigation are broken.

Steps to reproduce

'None'

  1. Go to the Primary navigation setting at /admin/appearance/settings/[site-name]
  2. Scroll down and click to open Navigation
  3. In the Dropdown type, select Inline
  4. Save the configuration and view the Primary nav on the front end

'Dropdown'

  1. Go to the Primary navigation setting at /admin/appearance/settings/[site-name]
  2. Scroll down and click to open Navigation
  3. In the Dropdown type, select Dropdown
  4. Save the configuration and view the Primary nav on the front end

Observed outcome

'None'

  1. The menu links are horizontally misaligned
  2. The menu links are too close together. Currently 1rem / 16px
Inline

'Dropdown'

  1. When dropdown isn't open the menu links are too close together. There is no padding between the chevron icon and the next menu link.
Dropdown

Expected outcome

'None'

  1. Menu links should horizontally align with the Search link
  2. Column gap should be 2 rem / 32px

'Drawer'

  1. There should be a gap of 32px between the chevron and the next menu item (16px padding side on each menu link)

Design

https://www.figma.com/design/i5NTcjBsg2zVjAxUvOl5oU/CivicTheme%3A-Design-System-v1.8.0?node-id=2976-42135&m=dev

@fionamorrison23 fionamorrison23 added the Type: Defect Issue is a defect label Dec 24, 2024
@github-project-automation github-project-automation bot moved this to Todo in UI Kit Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Defect Issue is a defect
Projects
Status: Todo
Development

No branches or pull requests

1 participant